Should throw on invaid (a = 1) = t

[fisker]

This should be invalid.

require("espree").parse('(a = 1) = 2', {sourceType: 'module', ecmaVersion: 2019}).body[0].expression
Node {
  type: 'AssignmentExpression',
  start: 0,
  end: 11,
  operator: '=',
  left: Node {
    type: 'AssignmentPattern',
    start: 1,
    end: 6,
    left: Node { type: 'Identifier', start: 1, end: 2, name: 'a' },
    right: Node { type: 'Literal', start: 5, end: 6, value: 1, raw: '1' }
  },
  right: Node { type: 'Literal', start: 10, end: 11, value: 2, raw: '2' }
}

[aladdin-add]

is it happening in acorn.js ?

[fisker]

As I tested, yes, it happens in acorn too. I'll open a issue there.

[fisker]

acornjs/acorn#1017, should I close this?

[aladdin-add]

as it's also a bug in espree, I suggest to keep it open to track it.

we can close it when the issue was fixed in acorn, and espree update its dependency acorn.

[mdjermanovic]

I think this is the same as acornjs/acorn#886 which has been fixed by acornjs/acorn@1d5b531 and released in Acorn 8.0.0.

We'll update Acorn dependency in the next Espree major version (#456).