Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken scripts in tools/ and convert to esm #471

Closed
mreinstein opened this issue Mar 17, 2021 · 2 comments · Fixed by #476
Closed

Fix broken scripts in tools/ and convert to esm #471

mreinstein opened this issue Mar 17, 2021 · 2 comments · Fixed by #476
Assignees
@nzakas
Labels
accepted chore
Projects
Triage

Comments

@mreinstein
Copy link
Contributor

As per discussion in #469 (comment) there are several files in the tools/ directory that are not functioning, and are also declared as commonjs modules.
@nzakas nzakas added this to Needs Triage in Triage via automation Mar 18, 2021
@nzakas nzakas moved this from Needs Triage to Evaluating in Triage Mar 18, 2021
@nzakas nzakas moved this from Evaluating to RFC Opened in Triage Mar 18, 2021
@nzakas nzakas moved this from RFC Opened to Evaluating in Triage Mar 18, 2021
@nzakas nzakas moved this from Evaluating to Ready to Implement in Triage Mar 18, 2021
@nzakas
Copy link
Member

nzakas commented Mar 18, 2021

Thanks!

@mdjermanovic mdjermanovic mentioned this issue Apr 11, 2021
Merged
@nzakas nzakas self-assigned this Apr 16, 2021
@nzakas
Copy link
Member

nzakas commented Apr 16, 2021

Working on this.

nzakas added a commit that referenced this issue Apr 16, 2021
@nzakas
Chore: Fix/remove tools (fixes #471)
8c0027d
@mdjermanovic mdjermanovic linked a pull request Apr 19, 2021 that will close this issue
Chore: Fix/remove tools (fixes #471) #476
Merged
Triage automation moved this from Ready to Implement to Complete Apr 21, 2021
nzakas added a commit that referenced this issue Apr 21, 2021
@nzakas
Chore: Fix/remove tools (fixes #471) (#476)
651e204 
* Chore: Fix/remove tools (fixes #471)

* Update tests tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nzakas nzakas

Labels
accepted chore
Projects
Triage
Archived in project
Triage
Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chore: Fix/remove tools (fixes #471) eslint/espree
2 participants
@nzakas @mreinstein