You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
npm version to update package.json. commit that change, and create git tag.
But now we should have something like this:
Update the changelog and commit that change.
npm version to update package.json. commit that change, and create git tag.
npm run rollup.
npm test
An additional question is whether or not should we commit lib/version.js. It might make sense to have a fixed "master" (or "main") as the version string in the repo.
I agree that it doesn't make sense to commit the changed version.js into the repo. It's a simpler release process if update the file during the release and then discard it.
After we merge #469, we should update the release process to account for an additional build step.
The new build step (
npm run rollup
in #469) does two things:package.json
to updatelib/version.js
.dist/espree.cjs
.Current steps in generateRelease are:
npm test
.npm version
to updatepackage.json
. commit that change, and create git tag.But now we should have something like this:
npm version
to updatepackage.json
. commit that change, and create git tag.npm run rollup
.npm test
An additional question is whether or not should we commit
lib/version.js
. It might make sense to have a fixed"master"
(or"main"
) as the version string in the repo.Previous discussion: #469 (comment)
The text was updated successfully, but these errors were encountered: