Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

espree v8 release process #475

Closed
mdjermanovic opened this issue Apr 11, 2021 · 2 comments · Fixed by #478
Closed

espree v8 release process #475

mdjermanovic opened this issue Apr 11, 2021 · 2 comments · Fixed by #478

Comments

@mdjermanovic
Copy link
Member

After we merge #469, we should update the release process to account for an additional build step.

The new build step (npm run rollup in #469) does two things:

  1. Reads the new version from package.json to update lib/version.js.
  2. Creates dist/espree.cjs.

Current steps in generateRelease are:

  1. npm test.
  2. Update the changelog and commit that change.
  3. npm version to update package.json. commit that change, and create git tag.

But now we should have something like this:

  1. Update the changelog and commit that change.
  2. npm version to update package.json. commit that change, and create git tag.
  3. npm run rollup.
  4. npm test

An additional question is whether or not should we commit lib/version.js. It might make sense to have a fixed "master" (or "main") as the version string in the repo.

Previous discussion: #469 (comment)

@eslint-github-bot eslint-github-bot bot added this to Needs Triage in Triage Apr 11, 2021
@mdjermanovic mdjermanovic moved this from Needs Triage to Evaluating in Triage Apr 11, 2021
@nzakas nzakas moved this from Evaluating to Blocked in Triage Apr 13, 2021
@nzakas
Copy link
Member

nzakas commented Apr 16, 2021

I agree that it doesn't make sense to commit the changed version.js into the repo. It's a simpler release process if update the file during the release and then discard it.

@nzakas
Copy link
Member

nzakas commented Apr 16, 2021

It looks like we can handle a lot of this complexity by using a prepare script, which will run before npm test and also before npm publish.

@mdjermanovic mdjermanovic linked a pull request Apr 19, 2021 that will close this issue
Triage automation moved this from Blocked to Complete Apr 19, 2021
mdjermanovic pushed a commit that referenced this issue Apr 19, 2021
* Build: Update scripts for release (fixes #475)

* Update scripts

* Update CI script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Triage
Complete
Development

Successfully merging a pull request may close this issue.

2 participants