Update: add class fields (refs eslint/eslint#14343) #486
Conversation
|
Hmmm. The build step makes developing new syntax on cross-packages difficult. 😟
|
|
for local development, you can use npm link However, I don't think there is an easy way to run on CI. |
Maybe comment out |
|
Switched to a draft for work-in-progress changes. |
|
You can also use a preinstall npm script. That might be easier to remove before merging. |
This reverts commit 3e9caa7.
Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>
|
@mysticatea what is left to do on this PR? Is anything we can help with? |
|
@mysticatea seems it is ready to go (the deps has been released & updated). |
|
Any news? |
|
@sanex3339 all news is posted on the pull request. |
| sourceType: "module" | ||
| }, | ||
| overrides: [ | ||
| { | ||
| files: ["tests/lib/**"], | ||
| files: ["*.cjs"], | ||
| parserOptions: { | ||
| ecmaVersion: 2020 | ||
| }, | ||
| sourceType: "script" |
There was a problem hiding this comment.
@mysticatea doesn't plugin:node/recommended already handle this?
| "type": "PrivateIdentifier", | ||
| "value": "a", |
There was a problem hiding this comment.
Token's value intentionally doesn't contain #?
There was a problem hiding this comment.
Given that the work appears done and we haven’t heard back from @mysticatea, I think we should merge this and handle any small issues separately.
|
There are merge conflicts that should be resolved |
|
Yup, all fixed now. |
|
Thank you for this PR |
WIP.
This PR adds ES2022 class features.
Remaining steps:
dist.eslint-visitor-keys.eslint-visitor-keysversion range in package.json.Also, because I expect ESLint built-in rules have false positives about the new syntax, I hope to release this feature together with built-in rules updates.