Fix: 0x2028 and 0x2029 in string literals should increment line number #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And acorn v8.5.0 supports class static blocks, I will make another PR to add some tests. |
👍 great, thanks! I just wanted to make a quick fix to unblock #513 for the case that we decide to release it this week. |
nzakas
approved these changes
Sep 8, 2021
@aladdin-add are you working on this? It's likely that we'll soon have a release to support |
|
not yet, I've got some RL stuff, but it's still in my todo list. please feel free to take it if you want. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades acorn to the latest v8.5.0, which includes a bug fix acornjs/acorn@147b99e -
0x2028and0x2029source code characters should increment line numbers inloceven if they're in string literals.Our tests are now updated to reflect this change.