Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support arbitrary module namespace names #528

Merged
merged 1 commit into from Dec 29, 2021
Merged

feat: support arbitrary module namespace names #528

merged 1 commit into from Dec 29, 2021

Conversation

mdjermanovic
Copy link
Member

Upgrades Acorn to support Arbitrary module namespace names.

@mdjermanovic mdjermanovic mentioned this pull request Dec 29, 2021
Closed
13 tasks
nzakas
nzakas approved these changes Dec 29, 2021
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nzakas nzakas merged commit 8655f3d into main Dec 29, 2021
@nzakas nzakas deleted the arbitrary-module-namespace-names branch December 29, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzakas nzakas nzakas approved these changes

@aladdin-add aladdin-add aladdin-add approved these changes

Assignees
No one assigned
Labels
accepted feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdjermanovic @nzakas @aladdin-add