Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Derive espree.Syntax from espree.VisitorKeys #532

Merged
merged 2 commits into from Feb 9, 2022

Conversation

codeworrior
Copy link
Contributor

Fixes #531.

If removing the lib/ast-node-types.js is regarded as an incompatible change, I can restore it and leave the cleanup up to you in one of the upcoming major releases. My assumption was that the module is rather an internal thing and not part of your APIs.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 26, 2022

CLA Signed

The committers are authorized under a signed CLA.

@eslint-github-bot
Copy link

Hi @codeworrior!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@codeworrior codeworrior changed the title Fix: Derive espree.Syntax from espree.VisitorKeys fix: Derive espree.Syntax from espree.VisitorKeys Jan 26, 2022
@codeworrior
Copy link
Contributor Author

Sorry for not immediately signing the CLA. I have to clarify with my employer first.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just want another set of eyes before merging.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Waiting for CLA before merging.

@codeworrior
Copy link
Contributor Author

Sorry for the delay. After my employer decided to sign the corporate CLA, we struggled a bit with the process and tooling, but now we're done.

@mdjermanovic mdjermanovic merged commit 64010de into eslint:main Feb 9, 2022
@mdjermanovic
Copy link
Member

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChainExpression and others are missing in espree.Syntax
3 participants