fix: "use strict" should not trigger strict mode in es3. #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
force-pushed
the
eslint-issue-15456
branch
2 times, most recently
from
5b853b6
to
089a6fd
Compare
aladdin-add
force-pushed
the
eslint-issue-15456
branch
from
089a6fd
to
9729e78
Compare
| "value": "use strict", | ||
| "raw": "\"use strict\"" | ||
| }, | ||
| "directive": "use strict" |
There was a problem hiding this comment.
I'm not sure if this should be reported to Acorn as a possible bug. As far as I know, ES3 didn't have the concept of directive prologues, so maybe no nodes should be parsed as Directive nodes in ES3 mode.
There was a problem hiding this comment.
👍 sounds a bug in acorn.
There was a problem hiding this comment.
Agree. This seems like a bug in Acorn.
mdjermanovic
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
LGTM, thanks!
I think we should merge this (and release it next week) regardless of #547 (comment) to ensure consistent behavior of Espree in regard to whether parsing produces syntax errors or not.
nzakas
reviewed
Apr 27, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.