New: Changing Base Path of overrides and ignorePatterns
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysticatea
added
the
Initial Commenting
mysticatea
changed the title
overrides and ignorePatterns that CLI Options Specifyoverrides and ignorePatterns
ljharb
approved these changes
Sep 19, 2019
gziolo
approved these changes
Sep 19, 2019
There was a problem hiding this comment.
This will solve the issue I reported in eslint/eslint#12278. In fact, I took the new proposed behavior for granted for both the shared ESLint config and the list of ignores. I'm sure this will help to provide solid configurations for big projects like WordPress (https://www.npmjs.com/package/@wordpress/scripts) which offer reusable scripts with default configs which are distributed as CLI commands executed using sourced located in node_modules folder.
designs/2019-changing-base-path-in-config-files-that-cli-options-specify/README.md
Show resolved
Hide resolved
designs/2019-changing-base-path-in-config-files-that-cli-options-specify/README.md
Show resolved
Hide resolved
platinumazure
approved these changes
Oct 11, 2019
ilyavolodin
approved these changes
Oct 11, 2019
kaicataldo
approved these changes
Oct 11, 2019
mysticatea
added
Final Commenting
|
I have moved this RFC to the final commenting phase because the team looks approving. |
mysticatea
deleted the
changing-base-path-of-overrides-and-ignorepatterns-that-cli-options-specify
branch
mysticatea
added a commit
to eslint/eslint
that referenced
this pull request
Feb 8, 2020
mysticatea
added a commit
to eslint/eslint
that referenced
this pull request
Mar 23, 2020
anikethsaha
pushed a commit
to anikethsaha/eslint
that referenced
this pull request
Mar 23, 2020
kaicataldo
added a commit
to eslint/eslint
that referenced
this pull request
Mar 27, 2020
* Breaking: change relative paths with --config (refs eslint/rfcs#37) * update docs * Breaking: improve plugin resolving (refs eslint/rfcs#47) * replace getRules by getRulesForFile (refs eslint/rfcs#47) * replace rulesMeta by getRuleMeta (refs eslint/rfcs#47) * replace report.usedDeprecatedRules by report.results[].usedDeprecatedRules * Revert "replace report.usedDeprecatedRules by report.results[].usedDeprecatedRules" This reverts commit f3cc32f. * Revert "replace rulesMeta by getRuleMeta (refs eslint/rfcs#47)" This reverts commit 0d6afaf. * Revert "replace getRules by getRulesForFile (refs eslint/rfcs#47)" This reverts commit d29f613. * update docs * Update docs/user-guide/configuring.md Co-Authored-By: Kai Cataldo <kai@kaicataldo.com> * fix markdownlint error Co-authored-by: Kai Cataldo <kai@kaicataldo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This RFC changes the base path of
overrides,ignorePatterns, and.eslintignorefrom the directory which contains the config file to the current working directory if the config file was specified by CLI options--configor--ignore-path.Related Issues
overridesfrom config in npm package looks for files in node_modules eslint#12278