Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

20.1.0 release contains a breaking change #534

Closed
alexzherdev opened this issue Oct 31, 2018 · 3 comments
Closed

20.1.0 release contains a breaking change #534

alexzherdev opened this issue Oct 31, 2018 · 3 comments
Assignees
Labels
breaking This change is backwards-incompatible bug

Comments

@alexzherdev
Copy link

What version of TypeScript are you using?
3.1.3

What version of typescript-eslint-parser are you using?
20.1.0

What did you expect to happen?
When upgrading from 20.0.0 to 20.1.0 there are no breaking changes.

What happened?
As discussed in jsx-eslint/eslint-plugin-react#2032, changing a dep to peerDep in #526 is a breaking change.

@ljharb
Copy link
Sponsor

ljharb commented Oct 31, 2018

Adding a peer dep, or altering the version to make it more restrictive, is a breaking change. The peer dep change should be reverted and saved for v21.

@platinumazure
Copy link
Member

My apologies, I mislabeled the commit as a chore rather than breaking.

I'll revert the commit, cut a patch release, then redo the commit as breaking and cut a major release. I'm traveling today, so I greatly appreciate your patience as I find time to do this in between airline security, etc. Thanks for your understanding!

@platinumazure
Copy link
Member

I think I've published typescript-eslint-parser@20.1.1 reverting the peer dependency change. (I say "I think" because this is the first time I've used our new release pipeline with npm 2FA. I do see commits on GitHub and an artifact on npm, so hopefully all went well.)

I'm about to fly now, so I'll do the second part (apply the commit as breaking and cut major release) later today.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking This change is backwards-incompatible bug
Projects
None yet
Development

No branches or pull requests

4 participants