Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvements #1221

Open
6 of 14 tasks
jessebraham opened this issue Feb 28, 2024 · 3 comments
Open
6 of 14 tasks

Documentation improvements #1221

jessebraham opened this issue Feb 28, 2024 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation status:long-term This task will be around a while

Comments

@jessebraham
Copy link
Member

jessebraham commented Feb 28, 2024

There are a number of changes we would like to make to our documentation, so this will serve as a tracking issue (or an "epic", if you will) for each individual task.

If you would like to complete one of these tasks, please assign yourself to the issue if one already exists, or create a new issue and assign yourself to it.

@AnthonyGrondin
Copy link
Contributor

Not sure where to drop this, but if we want to test for documentation coverage of the public APIs in CI, we could do something like:

cargo rustdoc -q -- -Z unstable-options --show-coverage | grep -i total | grep -oE '[0-9]*\.[0-9]*%' | head -n1 | grep -q 100.0%
  1. Get lists of documentation coverage
  2. Get the last line, "total"
  3. Extract both percentage (doc, examples) from the line.
  4. Get first one (doc)
  5. Check if == 100%.

@jessebraham jessebraham self-assigned this Mar 5, 2024
@bjoernQ
Copy link
Contributor

bjoernQ commented Mar 5, 2024

We probably also want to double check what we want to hide from the docs

e.g. here: https://docs.rs/esp32s3-hal/0.15.0/esp32s3_hal/gpio/index.html - GpioXSignals is pretty much useless for users of the HAL

https://docs.rs/esp32s3-hal/0.15.0/esp32s3_hal/gpio/trait.GpioProperties.html - the whole trait is probably cryptic and useless for most users

Not a priority but always I look into the docs I think about this and quickly forget about then

@MabezDev MabezDev pinned this issue Mar 11, 2024
@jessebraham jessebraham added the status:long-term This task will be around a while label Mar 11, 2024
@playfulFence
Copy link
Contributor

Working on #1276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation status:long-term This task will be around a while
Projects
Status: Todo
Development

No branches or pull requests

5 participants