Add unsafe dma api #1523
Closed
Add unsafe dma api #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
reviewed
Apr 29, 2024
|
Marking this as draft for now. |
Thanks for reminding me of this. I will close this since we should find a better solution than going unsafe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 馃摑
CHANGELOG.mdin the proper section.Extra:
Pull Request Details 馃摉
Description
Fixes #1512
Bringing back the old clumsy API doesn't seem to be a good solution so this adds unsafe versions of write_dma, read_dma and transfer_dma for SPI master
Testing
Tested with https://github.com/bjoernQ/rust-esp32s3-ili9341 and the existing examples