Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fatfs: FF_USE_STRFUNC is not configurable, thus f_gets() is unavailable (IDFGH-12315) #13350

Closed
KJ7LNW opened this issue Mar 11, 2024 · 0 comments · Fixed by #13352
Closed

fatfs: FF_USE_STRFUNC is not configurable, thus f_gets() is unavailable (IDFGH-12315) #13350

KJ7LNW opened this issue Mar 11, 2024 · 0 comments · Fixed by #13352
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally Type: Feature Request Feature request for IDF

Comments

@KJ7LNW
Copy link
Contributor

KJ7LNW commented Mar 11, 2024

Is your feature request related to a problem?

Legacy fatfs code being ported to ESP-IDF may use f_gets(), f_puts(), and f_printf() calls, but the define FF_USE_STRFUNC is set to 0 without kconfig options to enable it.

Others have had this problem, and we just ran into it, too: https://esp32.com/viewtopic.php?t=17148

Describe the solution you'd like.

Enable kconfig options to appropriately set FF_USE_STRFUNC and related defines

Describe alternatives you've considered.

Could bring in the fatfs component and set FF_USE_STRFUNC myself in ffconf.h, but managing an already packaged dependency just to set a config option seems silly.

Additional context.

No response
@KJ7LNW KJ7LNW added the Type: Feature Request Feature request for IDF label Mar 11, 2024
KJ7LNW added a commit to KJ7LNW/esp-idf that referenced this issue Mar 11, 2024
@KJ7LNW
feat(fatfs): add Kconfig settings for FF_USE_STRFUNC
fd7ffb7 
Legacy fatfs code being ported to ESP-IDF may use `f_gets()`, `f_puts()`,
`f_putc()`, and `f_printf()` calls, but the define `FF_USE_STRFUNC` is set to 0
without Kconfig options to enable it.

This commit retains the existing default behavior of `FF_USE_STRFUNC=0` and
adds Kconfig settings so users can configure `FF_USE_STRFUNC` and the related
`FF_PRINT_LLI`, `FF_PRINT_FLOAT`, and `FF_STRF_ENCOD`E if needed.

Closes: espressif#13350
Signed-off-by: Eric Wheeler <esp-idf@z.ewheeler.org>
@espressif-bot espressif-bot added the Status: Opened Issue is new label Mar 11, 2024
@github-actions github-actions bot changed the title fatfs: FF_USE_STRFUNC is not configurable, thus f_gets() is unavailable fatfs: FF_USE_STRFUNC is not configurable, thus f_gets() is unavailable (IDFGH-12315) Mar 11, 2024
KJ7LNW added a commit to KJ7LNW/esp-idf that referenced this issue Mar 11, 2024
@KJ7LNW
feat(fatfs): add Kconfig settings for FF_USE_STRFUNC
2042135 
Legacy fatfs code being ported to ESP-IDF may use `f_gets()`, `f_puts()`,
`f_putc()`, and `f_printf()` calls, but the define `FF_USE_STRFUNC` is set to 0
without Kconfig options to enable it.

This commit retains the existing default behavior of `FF_USE_STRFUNC=0` and
adds Kconfig settings so users can configure `FF_USE_STRFUNC` and the related
`FF_PRINT_LLI`, `FF_PRINT_FLOAT`, and `FF_STRF_ENCODE` if needed.

Closes: espressif#13350
Signed-off-by: Eric Wheeler <esp-idf@z.ewheeler.org>
@KJ7LNW KJ7LNW mentioned this issue Mar 11, 2024
Closed
KJ7LNW added a commit to KJ7LNW/esp-idf that referenced this issue Mar 11, 2024
@KJ7LNW
feat(fatfs): add Kconfig settings for FF_USE_STRFUNC
575e2dd 
Legacy fatfs code being ported to ESP-IDF may use `f_gets()`, `f_puts()`,
`f_putc()`, and `f_printf()` calls, but the define `FF_USE_STRFUNC` is set to 0
without Kconfig options to enable it.

This commit retains the existing default behavior of `FF_USE_STRFUNC=0` and
adds Kconfig settings so users can configure `FF_USE_STRFUNC` and the related
`FF_PRINT_LLI`, `FF_PRINT_FLOAT`, and `FF_STRF_ENCODE` if needed.

Closes: espressif#13350
Signed-off-by: Eric Wheeler <esp-idf@z.ewheeler.org>
@KJ7LNW KJ7LNW mentioned this issue Mar 11, 2024
Merged
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally Type: Feature Request Feature request for IDF
Projects
None yet
Milestone
No milestone
2 participants
@espressif-bot @KJ7LNW