Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mqtt select calls' timeouts cluttering debug level logs (IDFGH-7893) #9415

Open
KaeLL opened this issue Jul 22, 2022 · 8 comments
Open

mqtt select calls' timeouts cluttering debug level logs (IDFGH-7893) #9415

KaeLL opened this issue Jul 22, 2022 · 8 comments
Assignees
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally

Comments

@KaeLL
Copy link
Contributor

KaeLL commented Jul 22, 2022

Problem Description

Do these really need to be DEBUG rather than VERBOSE?

D (16:26:43.753) TRANSPORT_BASE: poll_read: select - Timeout before any socket was ready!
D (16:26:43.754) TRANSPORT_BASE: poll_read: select - Timeout before any socket was ready!
D (16:26:43.754) mqtt_client: esp_mqtt_handle_transport_read_error: transport_read(): call timed out before data was ready!

Setting these components' log level to INFO would hide other relevant DEBUG level logs.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Jul 22, 2022
@github-actions github-actions bot changed the title mqtt select calls cluttering debug level logs mqtt select calls cluttering debug level logs (IDFGH-7893) Jul 22, 2022
@KaeLL KaeLL changed the title mqtt select calls cluttering debug level logs (IDFGH-7893) mqtt select calls timeout cluttering debug level logs (IDFGH-7893) Jul 22, 2022
@KaeLL KaeLL changed the title mqtt select calls timeout cluttering debug level logs (IDFGH-7893) mqtt select calls' timeouts cluttering debug level logs (IDFGH-7893) Jul 22, 2022
@moefear85
Copy link

moefear85 commented Jul 23, 2022

the timeouts are logged using the "TRANSPORT_BASE" tag, not "mqtt_client", so just use:

esp_log_level_set("TRANSPORT_BASE",ESP_LOG_NONE);

but place it after all setup so it doesn't get changed back.

@KaeLL KaeLL closed this as completed Aug 9, 2022
@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed Resolution: Done Issue is done internally Status: Done Issue is done internally and removed Status: Opened Issue is new Status: Reviewing Issue is being reviewed labels Sep 30, 2022
@KaeLL
Copy link
Contributor Author

KaeLL commented Mar 15, 2024

@moefear85 🤔
image
Again I ask: do these really need to be DEBUG rather than VERBOSE?

@KaeLL KaeLL reopened this Mar 15, 2024
@moefear85
Copy link

I'm neither a contributor nor maintainer... but you can search for the error message in vscode (or use grep) , then simply replace ESP_LOGD with ESP_LOGV. most likely it would be a one-liner edit.

@KaeLL
Copy link
Contributor Author

KaeLL commented Mar 16, 2024

@euripedesrocha

@euripedesrocha
Copy link
Collaborator

euripedesrocha commented Mar 20, 2024

@KaeLL this was already fixed in IDF 5.2, but looking closely to your new logs that are few other places in the mqtt client that have similar behavior. I'm fixing it.

Thanks for reopening.

@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Done Issue is done internally Resolution: Done Issue is done internally labels Mar 21, 2024
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: In Progress Work is in progress labels Apr 12, 2024
@AxelLin
Copy link
Contributor

AxelLin commented Apr 22, 2024

@euripedesrocha
IDF 5.0 and 5.1 still need fix.

@AxelLin
Copy link
Contributor

AxelLin commented May 18, 2024

@euripedesrocha IDF 5.0 and 5.1 still need fix.

@euripedesrocha
There is no update for IDF 5.0 and 5.1.
Now I'm wondering if you stop maintaining esp-mqtt for older release branches?

@euripedesrocha
Copy link
Collaborator

@AxelLin we didn't stop maintaining 5.0 and 5.1 branches. We just decided to not backport this at the moment. I'll reassess and maybe start the backport process. Sorry for let you request without an answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

No branches or pull requests

5 participants