Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for optional catch binding #383

Closed
wants to merge 2 commits into from
Closed

add support for optional catch binding #383

wants to merge 2 commits into from

Conversation

cixel
Copy link

@cixel cixel commented Oct 23, 2018

Fixes #382.

Tests rely on esprima 1953 or they will throw early:

  1) general test try statement:
     AssertionError: expected [Function] to not throw an error but 'Error: Line 1: Unexpected token {' was thrown
      at testIdentity (test/test.js:14946:23)
      at runTest (test/test.js:14974:9)
      at test/test.js:14983:17
      at Array.forEach (<anonymous>)
      at Context.<anonymous> (test/test.js:14981:41)

This PR can hibernate until there's progress on esprima's end, and until esprima dependency version bumps to 4.x+.

@sanex3339
Copy link
Contributor

Any update on this?

@sanex3339
Copy link
Contributor

@cixel

This was referenced Jan 3, 2020
Closed
Merged
@sanex3339
Copy link
Contributor

#398 is merged
Can you update this PR?

@sanex3339
Copy link
Contributor

If here will be no actions in the next few hours, i'll recreate this PR with updated esprima dependency.

@cixel
Copy link
Author

cixel commented Jan 5, 2020

Sorry, I've been away. It may be simplest for you to recreate the PR, I haven't touched this stuff in a while.

@cixel cixel closed this Jan 5, 2020
@sanex3339
Copy link
Contributor

Yep. I already did
#403

@cixel
Copy link
Author

cixel commented Jan 5, 2020

Good stuff. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support optional catch binding
2 participants
@cixel @sanex3339