Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to grpc 1.30.0 #12153

Closed
pracucci opened this issue Jul 20, 2020 · 6 comments
Closed

Upgrade to grpc 1.30.0 #12153

pracucci opened this issue Jul 20, 2020 · 6 comments

Comments

@pracucci
Copy link

We're using the etcd clientv3 in the Cortex project. We're currently blocked from upgrading some dependencies (ie. Prometheus) because of a breaking change introduced in grpc 1.30.0: the deprecated naming package (in grpc) has been removed.

What's the feeling about upgrading etcd to grpc 1.30.0?

@pracucci
Copy link
Author

To better understand how widespread the issue is in etcd, I've upgraded to grpc 1.30 forking the naming package:
master...pracucci:upgrade-to-grpc-1.30

@pracucci
Copy link
Author

Handling the removal of naming package looks relative easy. However, grpc 1.30.0 has also moved Balancer and Picker to V2 (and deleted the old one) in grpc/grpc-go#3431.

@pracucci
Copy link
Author

We should be able to solve this issue in Cortex using the replace directive in go.mod, but considering upgrading etcd to grpc 1.30 would be great.

@beorn7
Copy link
Contributor

beorn7 commented Jul 20, 2020

Sadly, the replace directive doesn't work to downgrade because grpc 1.30 is in a multi-module repo, but 1.29 is in a mono-module repo. The new example module that sprang into existence with 1.30 is incompatible with the old example subdir in 1.29, and we haven't found a way to replace a module with a subdir…

@xiegeo
Copy link

xiegeo commented Jul 23, 2020

Duplicate of #12124

@pracucci
Copy link
Author

Closing because it's a duplicate of #12124.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants