[v3.5] Change the default sampling rate from 100% to 0% #14310
Comments
|
Willing to work on this if no one else is already |
damemi
added a commit
to damemi/etcd
that referenced
this issue
Aug 5, 2022
This changes the default parent-based trace sampling rate from 100% to 0%. Due to the high QPS etcd can handle, having 100% trace sampling leads to very high resource usage. Defaulting to 0% means that only already-sampled traces will be sampled in etcd. Fixes etcd-io#14310
damemi
added a commit
to damemi/etcd
that referenced
this issue
Aug 5, 2022
This changes the default parent-based trace sampling rate from 100% to 0%. Due to the high QPS etcd can handle, having 100% trace sampling leads to very high resource usage. Defaulting to 0% means that only already-sampled traces will be sampled in etcd. Fixes etcd-io#14310 Signed-off-by: Mike Dame <mikedame@google.com>
|
fixed by #14318 |
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/etcd
that referenced
this issue
Oct 7, 2022
This changes the default parent-based trace sampling rate from 100% to 0%. Due to the high QPS etcd can handle, having 100% trace sampling leads to very high resource usage. Defaulting to 0% means that only already-sampled traces will be sampled in etcd. Fixes etcd-io#14310 Signed-off-by: Mike Dame <mikedame@google.com>
tjungblu
pushed a commit
to tjungblu/etcd
that referenced
this issue
Jul 26, 2023
This changes the default parent-based trace sampling rate from 100% to 0%. Due to the high QPS etcd can handle, having 100% trace sampling leads to very high resource usage. Defaulting to 0% means that only already-sampled traces will be sampled in etcd. Fixes etcd-io#14310 Signed-off-by: Mike Dame <mikedame@google.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Part of #12460.
Etcd, especially in a kubernetes cluster, handles very high QPS. In the initial version (#12919) of OpenTelemetry tracing, it did not set a sampler, which causes the sampling rate to default to sampling every request. This makes tracing virtually unusable on etcd 3.5.
When a sampler was added in 3.6, it changed to having it default to ParentBased(0), which is the preferred default.
I'd like to propose backporting this line, with
ParentBased(NeverSample())torelease-3.5to address this.cc @logicalhan @damemi @CatherineF-dev @dgrisonnet @serathius @sallyom
The text was updated successfully, but these errors were encountered: