Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Measure Test Flakiness #17774

Closed
serathius opened this issue Apr 11, 2024 · 4 comments · Fixed by #17893
Closed

Drop Measure Test Flakiness #17774

serathius opened this issue Apr 11, 2024 · 4 comments · Fixed by #17893
Assignees
@jimmy-bro
Labels
good first issue type/feature

Comments

@serathius
Copy link
Member

What would you like to be added?

https://github.com/etcd-io/etcd/actions/workflows/measure-test-flakiness.yaml consistently fails.

Don't think we should fix it as we building a replacement.

Before removal we should ensure that replacement is working correctly and runs every day instead of once per week.

Why is this needed?

We are migrating to https://github.com/etcd-io/etcd/actions/workflows/measure-testgrid-flakiness.yaml
@siyuanfoundation
Copy link
Contributor

cc @stackbaek

@jimmy-bro
Copy link

/assign

@jimmy-bro jimmy-bro mentioned this issue Apr 29, 2024
Merged
@stackbaek
Copy link

I just checked our testgrid, but it looks like there the 2 tabs we check to create issues does not have any flakiness currently:

image

Consulting the recent workflow ouptut, it does seem to pull the data correctly for both periodic and presubmit tests.

I think we can go ahead and deprecate measure-test-flakiness.yaml.

stackbaek pushed a commit to stackbaek/etcd that referenced this issue Apr 29, 2024
@keabsb
Deprecates measure-test-flakiness workflow
ba3844f 
This workflow is failing consistently and measure-testgrid seems
functional, per
etcd-io#17774 (comment)
@stackbaek
Copy link

It looks like #17893 is already ongoing. Let's proceed with the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimmy-bro jimmy-bro

Labels
good first issue type/feature
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

github workflow: drop measure test flakiness jimmy-bro/etcd
4 participants
@stackbaek @serathius @siyuanfoundation @jimmy-bro