Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use versions.json consistently in Circle CI config #10398

Open
sebastianst opened this issue May 3, 2024 · 0 comments
Open

ci: Use versions.json consistently in Circle CI config #10398

sebastianst opened this issue May 3, 2024 · 0 comments

Comments

@sebastianst
Copy link
Member

In #9117, installation of a new tool eth2-testnet-genesis was added to the Circle CI config. It references the version from the versions.json file. However, other software that is installed in CI still hardcodes the version, leading to inconsistent use of versions, for example (incomplete list)

  • nvm version
  • node version (the keyword nvm is used in versions.json to set the node version, this should also be improved)
  • geth
  • foundry

The version can be accessed like $(jq -r .eth2_testnet_genesis < versions.json), see also b9216e2.

Ideally we specify as many versions as possible in the versions.json file and then consistently use them across different contexts, e.g. in CI as well as the ci-builder.

Note that it may be necessary to specify additional versions in the versions file, and possibly also some checksums for some software, like geth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant