Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent storage location naming across repo #10427

Open
pegahcarter opened this issue May 6, 2024 · 1 comment
Open

Inconsistent storage location naming across repo #10427

pegahcarter opened this issue May 6, 2024 · 1 comment

Comments

@pegahcarter
Copy link
Contributor

Examples:

bytes32 public constant BATCH_INBOX_SLOT = bytes32(uint256(keccak256("systemconfig.batchinbox")) - 1);
/// @notice Storage slot for block at which the op-node can start searching for logs from.
bytes32 public constant START_BLOCK_SLOT = bytes32(uint256(keccak256("systemconfig.startBlock")) - 1);

bytes32 public constant PAUSED_SLOT = bytes32(uint256(keccak256("superchainConfig.paused")) - 1);

Recommendation: Use the same style for namespaces across contracts (ideally with ProperCase contracts and camelCase variables [example]).

@tynes
Copy link
Contributor

tynes commented May 7, 2024

This definitely slipped through review, I think its unlikely that we will migrate away from this now as there are more important things to focus on. You are right its better to standardize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants