Skip to content

Commit 63691c4

Browse files
ShravanSunderkrzkaczor
andauthoredMay 26, 2022
#692/discriminate fixes (#693)
Co-authored-by: Kris Kaczor <chris@kaczor.io>
1 parent 3cd2f50 commit 63691c4

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed
 

Diff for: ‎.changeset/wild-bags-attack.md

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@typechain/hardhat': minor
3+
'typechain': minor
4+
---
5+
6+
Expose `TypechainUserConfig` type.
7+
Removed `contractName` from interface output see #692 for details.

Diff for: ‎packages/hardhat/src/types.ts

+2-8
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,3 @@
1-
export interface TypechainUserConfig {
2-
outDir?: string
3-
target?: string
4-
alwaysGenerateOverloads?: boolean
5-
tsNocheck?: boolean
6-
externalArtifacts?: string[]
7-
}
8-
91
export interface TypechainConfig {
102
outDir: string
113
target: string
@@ -14,3 +6,5 @@ export interface TypechainConfig {
146
tsNocheck: boolean
157
externalArtifacts?: string[]
168
}
9+
10+
export interface TypechainUserConfig extends Partial<TypechainConfig> {}

Diff for: ‎packages/target-ethers-v5/src/codegen/index.ts

-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ export function codegenContractTypings(contract: Contract, codegenConfig: Codege
3939
${generateStructTypes(values(contract.structs).map((v) => v[0]))}
4040
4141
export interface ${contract.name}Interface extends utils.Interface {
42-
${codegenConfig.discriminateTypes ? `contractName: '${contract.name}';\n` : ``}
4342
functions: {
4443
${values(contract.functions)
4544
.flatMap((v) => v.map(generateInterfaceFunctionDescription))

Diff for: ‎packages/typechain/src/typechain/runTypeChain.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ interface Result {
1313
filesGenerated: number
1414
}
1515

16-
const DEFAULT_FLAGS: CodegenConfig = {
16+
export const DEFAULT_FLAGS: CodegenConfig = {
1717
alwaysGenerateOverloads: false,
1818
discriminateTypes: false,
1919
tsNocheck: false,

0 commit comments

Comments
 (0)
Please sign in to comment.