Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove outdated speedrunethereum tutorials #12834

Merged
merged 2 commits into from May 17, 2024

Conversation

ZakGriffith
Copy link
Contributor

@ZakGriffith ZakGriffith commented Apr 24, 2024

Description

Remove outdated speedrunethereum tutorials

Related Issue

@github-actions github-actions bot added the needs review 👀 Review is needed for this issue or pull request label Apr 24, 2024
@ZakGriffith
Copy link
Contributor Author

This references Issue #12835

Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 70d14e6
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6646b5db374f4d000826054d
😎 Deploy Preview https://deploy-preview-12834--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 48 (🔴 down 8 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 95 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks @ZakGriffith! Although the tutorials need pruning in general, we could consider just updating the links here... Looks like they've just been migrated to

Any reason you wanted to take them down instead of update?

@ZakGriffith
Copy link
Contributor Author

ZakGriffith commented Apr 26, 2024

Thank for the reply @wackerow! It appeared that when I added them all at the same time it grouped them all well in the list when not using any filtering. But if that isn't the case, I can edit to just update the two old tutorials and add in the other new ones.

@wackerow wackerow marked this pull request as draft May 7, 2024 21:45
@wackerow
Copy link
Member

wackerow commented May 7, 2024

@ZakGriffith Sounds good! Flipped this to draft until this is updated...

image

When it's ready just click Ready for review and @ me =)

@github-actions github-actions bot added the abandoned This has been abandoned or will not be implemented label May 7, 2024
@wackerow wackerow reopened this May 7, 2024
@ZakGriffith
Copy link
Contributor Author

Looking that PR#12836 was merged with these updated challenges. This PR can be safely closed without merge. Thank you @wackerow

@wackerow
Copy link
Member

Great, thanks @ZakGriffith!

@ZakGriffith
Copy link
Contributor Author

I apologize and was incorrect. With the merge of PR#12836 this one will also need merged as is because they are now duplicates of two challenges introduced in that PR. @wackerow

@ZakGriffith ZakGriffith reopened this May 11, 2024
@corwintines corwintines marked this pull request as ready for review May 17, 2024 01:36
@corwintines corwintines self-assigned this May 17, 2024
Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Checked this over and looked ready for review @ZakGriffith so I flipped it over. Going to bring this in, but if you think anything was missed let me know!

@corwintines corwintines merged commit ef191f3 into ethereum:dev May 17, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned This has been abandoned or will not be implemented needs review 👀 Review is needed for this issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stale external tutorials need removed/updated.
3 participants