Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI generates weird names for smart contract files #219

Open
krzkaczor opened this issue Jun 10, 2018 · 0 comments · May be fixed by #220
Open

CLI generates weird names for smart contract files #219

krzkaczor opened this issue Jun 10, 2018 · 0 comments · May be fixed by #220
Labels
good first issue low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. nice to have We don’t see a good reason not to have it but won’t go out of our way to implement it. refactor

Comments

@krzkaczor
Copy link

Command: solcjs --overwrite --abi --bin -o ./test/contract-artifacts ./test/contracts/*

When using native solc, generated files have reasonable names like DumbContract.abi, DumbContract.bin (same as original). With solcjs filenames contain full path like: __test_contracts_DumbContract_sol_DumbContract.abi

Is this behaviour intended? It makes it painful to work with generated files. We do it in integration tests for one of my projects and its super weird to work with these files later: https://github.com/Neufund/TypeChain/blob/master/test/integration/DumbContract.spec.ts#L5
@krzkaczor krzkaczor linked a pull request Jun 10, 2018 that will close this issue
Open
@cameel cameel changed the title CLI generates weird names for smart constracts files CLI generates weird names for smart contract files Oct 6, 2021
@cameel cameel added low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. nice to have We don’t see a good reason not to have it but won’t go out of our way to implement it. labels Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. nice to have We don’t see a good reason not to have it but won’t go out of our way to implement it. refactor
Projects
No open projects
solc-js
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change rules for selecting filename for generated files krzkaczor/solc-js
2 participants
@cameel @krzkaczor