Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading binaries from emscripten-asmjs/ and emscripten-wasm/ dirs in solc-bin #671

Open
cameel opened this issue Oct 6, 2022 · 0 comments
Labels
medium effort Default level of effort medium impact Default level of impact must have Something we consider an essential part of Solidity 1.0. refactor

Comments

@cameel
Copy link
Member

cameel commented Oct 6, 2022

We introduced the new directory structure in solc-bin quite a while ago and we're recommending it in Static Binaries. solc-js, however, still uses the legacy bin/ directory. We should switch to the new structure.

  • Make downloadCurrentVersion.ts use the new dirs.
  • Find any other places where we're using the old dirs and fix them too.
  • Fix all references to the old dirs in the README.

For reference, Truffle has recently switched to the new structure too: trufflesuite/truffle#5008.

@cameel cameel added medium effort Default level of effort medium impact Default level of impact must have Something we consider an essential part of Solidity 1.0. refactor labels Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium effort Default level of effort medium impact Default level of impact must have Something we consider an essential part of Solidity 1.0. refactor
Projects
None yet
Development

No branches or pull requests

1 participant