Add fromMnemonic function #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @acolytec3 @paulmillr @holgerd77 Thank you for your great works of the crypto libraries though @paulmillr you are doing a god's work |
paulmillr
approved these changes
Aug 25, 2023
|
this is fine, however, the repository is deprecated and has been merged into ethereumjs-monorepo. So, we need to archive this gh repo. Would it be possible for you to submit a pull request to monorepo? |
added 2 commits
August 26, 2023 06:01
ghost
mentioned this pull request
|
Closing as it is not going to merged I guess, for anyone who wants this feature you can use the latest @ethereumjs/wallet package https://github.com/ethereumjs/ethereumjs-monorepo/releases/tag/%40ethereumjs%2Fwallet%402.0.1 or ethers.js |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #178
Requiring BIP39 dependency is useless since the functionality of converting BIP39 mnemonic phrases are already in the imported package.
And, lower count of dependency => better security for the codebase