TypeError when deploying contracts if the bytecode is too long.

[cubele]

Ethers Version

6.8.1

Search Terms

regex, bytecode

Describe the Problem

When calling ContractFactory.fromSolidity, an assertion fails with message invalid BytesLike value.
After stacktracing I found that the getBytes function in lib.commonjs uses the following code to check the validity of the contract bytecode:typeof (value) === "string" && value.match(/^0x([0-9a-f][0-9a-f])*$/i)). This regex match seems to crash and matches null for very long strings even if it's valid.
In my case, I tried to deploy a contract with ~21Kib size and it failed. I believe the problem is within the regex. I don't know if this is normal for the js regex engine, but a simpler check for this is definitely possible.

Code Snippet

const ContractInstance = ethers.ContractFactory.fromSolidity(contract, signer); // contract here has ~21KiB deployed size.

Contract ABI

No response

Errors

TypeError: invalid BytesLike value (argument="value", value="0x...")
 at assert (node_modules/ethers/lib.commonjs/utils/errors.js:149:15)
    at assertArgument (node_modules/ethers/lib.commonjs/utils/errors.js:161:5)
    at _getBytes (node_modules/ethers/lib.commonjs/utils/data.js:27:36)
    at getBytes (node_modules/ethers/lib.commonjs/utils/data.js:37:12)
    at new ContractFactory (node_modules/ethers/lib.commonjs/contract/factory.js:46:72)
    at ContractFactory.fromSolidity (node_modules/ethers/lib.commonjs/contract/factory.js:112:16)

Environment

No response

Environment (Other)

No response

[ZakaryaCH]

Hi @cubele,

Did you find a solution for this issue ?

[cubele]

Hi @cubele,

Did you find a solution for this issue ?

No, I ended up removing the validity check as a workaround.

[ricmoo]

Can you include the bytecode you used to cause this? There definitely shouldn't be a limit on string length (except memory constraints of the actual system).

What environment (e.g. chrome browser, node, Duktape) are you using?

[ricmoo]

Moving to discussions; if you have more feedback, please add it and we can always migrate back to an issue. :)