Skip to content

Unsupported ABI type - receive #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
superoo7 opened this issue Mar 8, 2020 · 13 comments
Closed

Unsupported ABI type - receive #746

superoo7 opened this issue Mar 8, 2020 · 13 comments
Labels
discussion Questions, feedback and general information.

Comments

@superoo7
Copy link

superoo7 commented Mar 8, 2020

In solidity 0.6.0, there is new receive() method where it allows ether deposit to a contract

receive() external payable {
}

Apparently, I got warning in my console, whenever I try to use ethers.Contract's method

WARNING: unsupported ABI type - receive
@ricmoo
Copy link
Member

ricmoo commented Mar 8, 2020

Yes, this is coming soon. :)

Thanks, I'll use this issue to track the progress. ;)

@ricmoo ricmoo added discussion Questions, feedback and general information. on-deck This Enhancement or Bug is currently being worked on. labels Mar 8, 2020
@superoo7
Copy link
Author

superoo7 commented Mar 8, 2020

Thanks a lot @ricmoo for the quick response, looking forward for the next release

@yahgwai
Copy link

yahgwai commented Mar 17, 2020

Is there any way to suppress this warning in the meantime?

@ricmoo
Copy link
Member

ricmoo commented Mar 21, 2020

This has been added to 5.0.0-beta.177 (i.e. the receive is dropped; in the future it may be available along with the fallback as a special function) . Please try it out and let meetups know if you still have any problems. :)

@gitpusha
Copy link

Hi @ricmoo . I am getting a WARNING: unsupported ABI type - receive on ethers 4.0.46, too.

Do I need to upgrade to 5.0.0-beta.177 still or will this be included in 4 any time soon?

@ricmoo
Copy link
Member

ricmoo commented Mar 26, 2020

I wasn’t planning on porting this back to v4 (it’s just a warning, no?).

But I’ll be going through more issues today, trying to close as many down as possible to prepare for the v5 release; if I find other changes that need to go into v4, I’ll sweep this in too (since I think it should be easy).

I can update the code regardless, but otherwise not sure when the next v4 release would be made.

@yahgwai
Copy link

yahgwai commented Mar 26, 2020

Yeah, would be great if it get's swept in. It is just a warning, but it's polluting my logs a lot :)

@stonecoldpat
Copy link

Screen Shot 2020-03-31 at 17 45 17

I've had to comment it out for now, it kept spamming my console lol. +1 for fixing in V4!

@yahgwai
Copy link

yahgwai commented Apr 21, 2020

We're about to ship a client library which has ethersjs as a dependency - the library deploys contracts with a receive function and as such they log this warning. At the moment I plan to replace the global console.log object with one that filters this message out. Any other ideas?

@yahgwai
Copy link

yahgwai commented Apr 21, 2020

We're about to ship a client library which has ethersjs as a dependency - the library deploys contracts with a receive function and as such they get they receive this warning. At the moment I plan to replace the global console.log object with one that filters this message out. Any other ideas?

@yahgwai
Copy link

yahgwai commented Apr 21, 2020

We're about to ship a client library which has ethersjs as a dependency - the library deploys contracts with a receive function and as such they log this warning. At the moment I plan to replace the global console.log object with one that filters this message out. Any other ideas?

ricmoo added a commit that referenced this issue Apr 22, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@ricmoo ricmoo removed the on-deck This Enhancement or Bug is currently being worked on. label Apr 22, 2020
@ricmoo
Copy link
Member

ricmoo commented Apr 22, 2020

Sorry for the delay. This has been merged and published in 4.0.47. Let me know if you still have any problems.

Thanks! :)

@ricmoo ricmoo closed this as completed Apr 22, 2020
@yahgwai
Copy link

yahgwai commented Apr 22, 2020

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Questions, feedback and general information.
Projects
None yet
Development

No branches or pull requests

5 participants