Update getTransactionSuccess to decode logs

[pfletcherhill]

Update getTransactionSuccess method to optionally decode logs

Issue Type

• Bug (https://github.com/ethjs/ethjs/blob/master/.github/CONTRIBUTING.md#bug-reports)
• Feature (https://github.com/ethjs/ethjs/blob/master/.github/CONTRIBUTING.md#feature-requests)

Description

The getTransactionSuccess method is helpful, but I'd like it to be able to decode returned logs as well. The method could either take as argument an ABI or could be added as a method to a contract instance (i.e. contractInstance.getTransactionSuccess("<txHash>")).

I've found myself creating a log decoder (i.e. const decoder = Eth.abi.logDecoder(<ABI>)) and running logs returned via getTransactionSuccess through that decoder, and it would be nice to have the method do that for me.

[SilentCicero]

Great idea! Would you like to make a pr ;)

…

Sent from my iPhone

On May 1, 2018, at 9:30 PM, Paul Fletcher-Hill ***@***.***> wrote: Update getTransactionSuccess method to optionally decode logs Issue Type Bug (https://github.com/ethjs/ethjs/blob/master/.github/CONTRIBUTING.md#bug-reports) Feature (https://github.com/ethjs/ethjs/blob/master/.github/CONTRIBUTING.md#feature-requests) Description The getTransactionSuccess method is helpful, but I'd like it to be able to decode returned logs as well. The method could either take as argument an ABI or could be added as a method to a contract instance (i.e. contractInstance.getTransactionSuccess("<txHash>")). I've found myself creating a log decoder (i.e. const decoder = Eth.abi.logDecoder(<ABI>)) and running logs returned via getTransactionSuccess through that decoder, and it would be nice to have the method do that for me. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[pfletcherhill]

Sure thing. Will open one by this weekend!