Request async iterator #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hbgl thank you for the contribution. |
|
FYI, this change broke support for Node.js 8, so we're pinning to 1.12.2. Bet you didn't think anyone was still using Node.js 8, huh? 😁 We have some extremely old legacy packages which use Node.js 8, which we still rebuild from time to time. Not a big deal of course! Just thought you might be interested to know. |
|
Hi @s100 thanks for reporting the issue, but we do not support Node.js 8 anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #277
Implement the async iterator protocol for mock request.
The request emits a new custom event
'async_iterator'after a new async iterator is created. Async iterators are generally created lazily on demand. The async iterator will only yield data that is sent after it has been created since the request does not have an internal buffer (unlike stream.Readable). Without the new event it would be hard to know when exactly it is okay send data because you might sent it before the async iterator has been created. Check this test case for how to use the new event.