Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create_float_source code generate many nan values in matrix files #219

Open
kamwal opened this issue May 5, 2022 · 5 comments
Open

create_float_source code generate many nan values in matrix files #219

kamwal opened this issue May 5, 2022 · 5 comments
Labels
argo-core About core variables (P, T, S) argo-deep About deep variables (anything below 2000db) forQCexpert Argo QC expertise is required invalid This doesn't seem right

Comments

@kamwal
Copy link

kamwal commented May 5, 2022

I have found that the python code to create_source_data is generating many nan values in SAL and TEMP data of WMO matrix .mat. While in netcdf files or in matlab equivalent code to create_source_data are showing much more available numeric data.

Example float with this issue: 6901967; 6901969

The reduced amount of data will lead to poorer owc estimates.

I am using the argopy v0.1.11 version.
@kamwal kamwal added invalid This doesn't seem right argo-core About core variables (P, T, S) argo-deep About deep variables (anything below 2000db) labels May 5, 2022
@gmaze
Copy link
Member

gmaze commented May 16, 2022

Hi @kamwal
Like in #218 could you please share files generated with the Matlab code ?

@kamwal
Copy link
Author

kamwal commented May 16, 2022

6901967.zip
The key issue for this example is below around 360 dbar where the python code is generating very sparse data values for PSAL and TEMP. While in Matlab version matrix shows much more available numeric data.

@github-actions
Copy link

This issue was marked as staled automatically because it has not seen any activity in 90 days

@github-actions github-actions bot added the stale No activity over the last 90 days label Aug 14, 2022
@gmaze gmaze removed the stale No activity over the last 90 days label Sep 23, 2022
@gmaze gmaze added the forQCexpert Argo QC expertise is required label Nov 2, 2022
@github-actions
Copy link

This issue was marked as staled automatically because it has not seen any activity in 90 days

@github-actions github-actions bot added the stale No activity over the last 90 days label Jan 31, 2023
@github-actions GitHub Actions
Copy link

This issue was closed automatically because it has not seen any activity in 365 days

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 13, 2024
@gmaze gmaze reopened this Apr 15, 2024
@github-actions github-actions bot removed the stale No activity over the last 90 days label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
argo-core About core variables (P, T, S) argo-deep About deep variables (anything below 2000db) forQCexpert Argo QC expertise is required invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmaze @kamwal