Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support retries in case of 429 response #31

Open
flimzy opened this issue Dec 15, 2016 · 0 comments · May be fixed by #34
Open

Support retries in case of 429 response #31

flimzy opened this issue Dec 15, 2016 · 0 comments · May be fixed by #34

Comments

@flimzy
Copy link
Contributor

flimzy commented Dec 15, 2016

Occasionally Sentry will respond with a 429 response.

It would be nice if there was an option to retry in this case.

I think perhaps the best way to do this would be in hook.SendPacket; if a 429* HTTP response is received, retry until the timeout is exceeded.

Whether this should be the default behavior or configurable are open questions in my mind.

What do you think?

*Maybe there are other statuses to be included here, too?

@flimzy flimzy linked a pull request Dec 20, 2016 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant