From 6b42c96fe4cb2a46d57c642d19e95410eddc0bc1 Mon Sep 17 00:00:00 2001 From: Evan Wallace Date: Tue, 8 Jun 2021 11:52:19 -0700 Subject: [PATCH] fix #1358: remove warning about source map comment --- CHANGELOG.md | 4 ++++ internal/bundler/bundler.go | 1 - 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 81410f65381..08700925d05 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -32,6 +32,10 @@ This feature was contributed by [@chriscasola](https://github.com/chriscasola). +* Remove a warning about unsupported source map comments ([#1358](https://github.com/evanw/esbuild/issues/1358)) + + This removes a warning that indicated when a source map comment couldn't be supported. Specifically, this happens when you enable source map generation and esbuild encounters a file with a source map comment pointing to an external file but doesn't have enough information to know where to look for that external file (basically when the source file doesn't have an associated directory to use for path resolution). In this case esbuild can't respect the input source map because it cannot be located. The warning was annoying so it has been removed. Source maps still won't work, however. + ## 0.12.7 * Quote object properties that are modern Unicode identifiers ([#1349](https://github.com/evanw/esbuild/issues/1349)) diff --git a/internal/bundler/bundler.go b/internal/bundler/bundler.go index 33685ed0a5c..380be06eec8 100644 --- a/internal/bundler/bundler.go +++ b/internal/bundler/bundler.go @@ -577,7 +577,6 @@ func extractSourceMapFromComment( } // Anything else is unsupported - log.AddRangeWarning(&tracker, comment.Range, "Unsupported source map comment") return logger.Path{}, nil }