Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-deterministic module ordering and chunk hashes since v0.11.13 #1304

Closed
eelco opened this issue May 21, 2021 · 3 comments
Closed

Non-deterministic module ordering and chunk hashes since v0.11.13 #1304

eelco opened this issue May 21, 2021 · 3 comments

Comments

@eelco
Copy link
Contributor

eelco commented May 21, 2021

Observed when building our code base twice:

Run 1:

import {
  Folder,
  fileManager,
  updateModelErrors
} from "https://app.framerstatic.com/chunk-7MI3WOZG.js";
import "https://app.framerstatic.com/chunk-KE3Z4VU4.js";
import "https://app.framerstatic.com/chunk-V6WDQTIM.js";
import "https://app.framerstatic.com/chunk-BBCUBSXY.js";
import {
  EditableFile,
  dirname,
  log,
  nameAndExtensionFor,
  pathjoin,
  restoreExtension
} from "https://app.framerstatic.com/chunk-2LPVDXEF.js";
import "https://app.framerstatic.com/chunk-VHU2THJN.js";
import "https://app.framerstatic.com/chunk-OK5YLNGZ.js";

Run 2:

import {
  Folder,
  fileManager,
  updateModelErrors
} from "https://app.framerstatic.com/chunk-ZYEJSYSI.js";
import "https://app.framerstatic.com/chunk-OK5YLNGZ.js";
import {
  EditableFile,
  dirname,
  log,
  nameAndExtensionFor,
  pathjoin,
  restoreExtension
} from "https://app.framerstatic.com/chunk-7GKJRT75.js";
import "https://app.framerstatic.com/chunk-BBCUBSXY.js";
import "https://app.framerstatic.com/chunk-V6WDQTIM.js";
import "https://app.framerstatic.com/chunk-KE3Z4VU4.js";
import "https://app.framerstatic.com/chunk-VHU2THJN.js";

Most of the chunk hashes appear in both files, but in a completely different order. This obviously affects the chunk hashes of the files (as demonstrated by the first import).

The issue first occurs in 0.11.13 (and also the latest version, so I assume all subsequent versions, I’ve also tested with 0.11.12, 0.11.14, 0.11.17, 0.11.23 and 0.12.1).

This might be the return of #1075, but looking at the comparison I suspect 65a010f might be the culprit.

@evanw
Copy link
Owner

evanw commented May 26, 2021

Thanks for the report. I agree with your assessment. The next release will contain a fix that should hopefully solve this regression.

@evanw
Copy link
Owner

evanw commented May 27, 2021

The fix has been published as version 0.12.4. Can you try it out and see if that fixes this problem?

@eelco
Copy link
Contributor Author

eelco commented May 28, 2021

Yes, that seems to fix it, thank you!

@eelco eelco closed this as completed May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants