Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css transform does not end when css is lacking a closing bracket in selector #2276

Closed
sapphi-red opened this issue May 28, 2022 · 2 comments
Closed

Comments

@sapphi-red
Copy link
Contributor

When input css has an invalid syntax (lacking a closing bracket in selector), esbuild transform does not end.

For example:

:where( {}

and

:where(blockquote, :not(ltr) {
  border-left-width: 3px
}
:where(blockquote, :not(rtl) {
  border-right-width: 3px
}

Original issue: vitejs/vite#8034
My thoughts: vitejs/vite#8034 (comment)
Reproduction: stack blitz (node esbuild.js)

@sapphi-red sapphi-red changed the title css transform does not end with css lacking a closing bracket in selector css transform does not end when css is lacking a closing bracket in selector May 28, 2022
@evanw
Copy link
Owner

evanw commented May 29, 2022

Thanks for the report! Sorry about that. I'll fix this in the next release.

@evanw evanw closed this as completed in 538c3d5 May 29, 2022
@sapphi-red
Copy link
Contributor Author

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants