Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"use strict" should not be emitted when format is ESM #2347

Closed
curiousdannii opened this issue Jun 24, 2022 · 1 comment
Closed

"use strict" should not be emitted when format is ESM #2347

curiousdannii opened this issue Jun 24, 2022 · 1 comment

Comments

@curiousdannii
Copy link

curiousdannii commented Jun 24, 2022 •
edited

#2264 added "use strict" when the tsconfig option alwaysStrict is true, but it emits it even when the format is ES modules. ES modules are always in strict mode, so the pragma is unnecessary. It should only be added if the format is not ESM.
@susiwen8 susiwen8 mentioned this issue Jun 24, 2022
Closed
@evanw evanw closed this as completed in 5d7ac55 Jun 24, 2022
@curiousdannii
Copy link
Author

Beautiful, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: esm don't need use strict
1 participant
@curiousdannii