don't leak memory on first incremental build error #2418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiya! This is kind of an aside to #1606 and #2280.
Presently, the
esbuildserver process leaks memory associated with theactiveBuildand everything about it if abuild({ incremental: true })fails (rather than a rebuild from it), and there's no way for a user to recover from this.There's probably a nicer solution that involves giving the
rebuildback to the user in the thrown error, but as you've mentioned in #1606 (comment), the API gets a bit out of whack then and there's various things to ponder.A minimally correct solution — at least, one that seems strictly more correct than what we have now, and that doesn't change the API whatsoever — is to
rebuild-disposebefore calling back with the failure.