Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live-reload doesn't send SSE event with write: false when outdir is / #3027

Closed
somebody1234 opened this issue Mar 29, 2023 · 1 comment
Closed

Live-reload doesn't send SSE event with write: false when outdir is / #3027

somebody1234 opened this issue Mar 29, 2023 · 1 comment

Comments

@somebody1234
Copy link

somebody1234 commented Mar 29, 2023 •
edited

This might be because currently change events must specify the list of changed files - but "reload on any change" would (should) be possible even when write: false
@somebody1234 somebody1234 changed the title Live-reload doesn't send SSE event with write: false Live-reload doesn't send SSE event with write: false when outdir is / Mar 29, 2023
@somebody1234
Copy link
Author

somebody1234 commented Mar 29, 2023 •
edited

After further testing it only happens when outdir is /. This might be intentional but it'd be nice to output a warning when using watch + serve + outdir: "/"

@evanw evanw closed this as completed in f780ad3 Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@somebody1234