Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal error causing panic when certain class static blocks are present #3161

Closed
clydin opened this issue Jun 14, 2023 · 2 comments
Closed

Comments

@clydin
Copy link

clydin commented Jun 14, 2023

An internal check in 0.18.2 related to class downlevel info appears to be triggering and leading to a panic when --minify-syntax and --bundle are enabled with a static class block present that is empty or only contains certain expression statements. This does not occur in 0.18.1.

Minimal reproductions:
https://esbuild.github.io/try/#YgAwLjE4LjIALS1taW5pZnktc3ludGF4IC0tYnVuZGxlAGUAZW50cnkuanMAY2xhc3MgYSB7CiAgc3RhdGljIHt9Cn0
https://esbuild.github.io/try/#YgAwLjE4LjIALS1taW5pZnktc3ludGF4IC0tYnVuZGxlAGUAZW50cnkuanMAY2xhc3MgYSB7CiAgc3RhdGljIHsgYTsgfQp9
https://esbuild.github.io/try/#YgAwLjE4LjIALS1taW5pZnktc3ludGF4IC0tYnVuZGxlAGUAZW50cnkuanMAY2xhc3MgYSB7CiAgc3RhdGljIHsgU3ltYm9sLml0ZXJhdG9yOyB9Cn0

@clydin clydin changed the title Internal error Internal error causing panic when class static blocks are present Jun 14, 2023
@clydin clydin changed the title Internal error causing panic when class static blocks are present Internal error causing panic when certain class static blocks are present Jun 14, 2023
@evanw
Copy link
Owner

evanw commented Jun 15, 2023

Really sorry about that. This case didn't have test coverage apparently. I'll push out a fix for this. Thank you very much for the report.

@alan-agius4
Copy link

Thanks for the swift action @evanw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants