Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__commonJS should pass falsy define to shadow the global refrence #3378

Open
magic-akari opened this issue Sep 12, 2023 · 0 comments · May be fixed by #3381
Open

__commonJS should pass falsy define to shadow the global refrence #3378

magic-akari opened this issue Sep 12, 2023 · 0 comments · May be fixed by #3381

Comments

@magic-akari
Copy link
Contributor

image

I am using Vite, which uses esbuild under the hood.
When I was investigating why a package's exports were not working,
I found that the code was entering the AMD branch because my browser environment includes AMD, imported by Monaco.
However, I don't think the code wrapped in __commonJS should be going into the AMD branch.
@magic-akari magic-akari linked a pull request Sep 13, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: shadow global define in __commonJS magic-akari/esbuild
1 participant
@magic-akari