Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect to compile sass source code #3673

Open
yawntee opened this issue Feb 29, 2024 · 2 comments
Open

Incorrect to compile sass source code #3673

yawntee opened this issue Feb 29, 2024 · 2 comments

Comments

@yawntee
Copy link

yawntee commented Feb 29, 2024

The require of sass.dart.js will be rename to __require
image
image
But esbuild use global require to access object property
image
It will make Uncaught RangeError: Maximum call stack size exceeded when using monaco-editor
image
Maybe esbuild should only rename the expression of calling function

This is a minimal reproduction link: https://codesandbox.io/p/devbox/esbuild-issue-ws2f3n

@evanw
Copy link
Owner

evanw commented Mar 7, 2024

You did not follow the issue reporting instructions that you deleted when creating this issue. Please provide a way to reproduce your problem or this issue will be closed. Marking as unactionable for now.

@yawntee
Copy link
Author

yawntee commented Mar 13, 2024

You did not follow the issue reporting instructions that you deleted when creating this issue. Please provide a way to reproduce your problem or this issue will be closed. Marking as unactionable for now.

I have edited the issue description, and added a link to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants