Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenBSD arm64 support #3665

Open
ikmckenz opened this issue Feb 23, 2024 · 5 comments · May be fixed by #3674
Open

OpenBSD arm64 support #3665

ikmckenz opened this issue Feb 23, 2024 · 5 comments · May be fixed by #3674

Comments

@ikmckenz
Copy link

I'd love an arm64 version for OpenBSD, looks like there is an arm64 version for FreeBSD so hopefully the effort is minimal?
@evanw
Copy link
Owner

evanw commented Feb 23, 2024

Can you verify that esbuild builds and runs on that configuration? For example: installing Go, downloading this repo, and running go test ./internal/... to verify that basic tests pass?

@ikmckenz
Copy link
Author

ikmckenz commented Feb 23, 2024 •
edited

Looks good to me! It builds and the tests seem to pass.
Full output of the Go tests:

openbsd-dev$ go test ./internal/...
?   	github.com/evanw/esbuild/internal/api_helpers	[no test files]
?   	github.com/evanw/esbuild/internal/ast	[no test files]
?   	github.com/evanw/esbuild/internal/bundler	[no test files]
?   	github.com/evanw/esbuild/internal/cache	[no test files]
?   	github.com/evanw/esbuild/internal/cli_helpers	[no test files]
?   	github.com/evanw/esbuild/internal/config	[no test files]
?   	github.com/evanw/esbuild/internal/css_ast	[no test files]
ok  	github.com/evanw/esbuild/internal/bundler_tests	11.750s
ok  	github.com/evanw/esbuild/internal/compat	0.075s
ok  	github.com/evanw/esbuild/internal/css_lexer	0.080s
ok  	github.com/evanw/esbuild/internal/css_parser	0.638s
ok  	github.com/evanw/esbuild/internal/css_printer	0.156s
?   	github.com/evanw/esbuild/internal/graph	[no test files]
ok  	github.com/evanw/esbuild/internal/fs	0.088s
ok  	github.com/evanw/esbuild/internal/helpers	0.288s
ok  	github.com/evanw/esbuild/internal/js_ast	0.080s
ok  	github.com/evanw/esbuild/internal/js_lexer	0.201s
?   	github.com/evanw/esbuild/internal/linker	[no test files]
?   	github.com/evanw/esbuild/internal/renamer	[no test files]
ok  	github.com/evanw/esbuild/internal/js_parser	6.315s
ok  	github.com/evanw/esbuild/internal/js_printer	0.769s
ok  	github.com/evanw/esbuild/internal/logger	0.075s
?   	github.com/evanw/esbuild/internal/runtime	[no test files]
?   	github.com/evanw/esbuild/internal/sourcemap	[no test files]
?   	github.com/evanw/esbuild/internal/test	[no test files]
?   	github.com/evanw/esbuild/internal/xxhash	[no test files]
ok  	github.com/evanw/esbuild/internal/resolver	0.072s

And this is on OpenBSD on an Arm MacBook:

openbsd-dev$ uname -a
OpenBSD openbsd-dev.my.domain 7.4 GENERIC.MP#2273 arm64

@evanw
Copy link
Owner

evanw commented Feb 23, 2024

That's great, thanks!

@ikmckenz
Copy link
Author

Currently testing the cross build in this branch: https://github.com/ikmckenz/esbuild/tree/openbsd-arm64, but ran into a weird issue with Go. I think there may be an issue with go cross building to OpenBSD arm64, as even hello world fails to run correctly. Issue filed with Go here: golang/go#66040

@ikmckenz ikmckenz linked a pull request Mar 1, 2024 that will close this issue
Open
@ikmckenz
Copy link
Author

ikmckenz commented Mar 1, 2024 •
edited

Issue was the Go cross compiler not working correctly for the latest apple silicon chips, but when tested against an M1 it works without issue. That issue has also been resolved upstream in go. To that end I've opened a pull request for my branch here: #3674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add OpenBSD arm64 ikmckenz/esbuild
2 participants
@evanw @ikmckenz