Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supportRelativeURL should handle source as a url #218

Open
ckknight opened this issue Jul 21, 2018 · 1 comment
Open

supportRelativeURL should handle source as a url #218

ckknight opened this issue Jul 21, 2018 · 1 comment

Comments

@ckknight
Copy link

Despite the name of the argument, supportRelativeURL's second argument, url, will be mangled if it is a fully-qualified URL, leading to error paths like /Users/ckknight/Code/myproject/https:/github.com/ckknight/myproject/blob/... instead of the expected URL.

This can occur when "sources" within a .map file contains references to URLs instead of relative paths.
@basickarl basickarl mentioned this issue Jun 13, 2019
Closed
@pfhayes
Copy link

pfhayes commented Jul 4, 2023

Proposed fix is here: #332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ckknight @pfhayes