Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual cron job runs should be marked as timed out in the cron log #261

Open
ayust opened this issue Jul 21, 2017 · 5 comments
Open

Comments

@ayust
Copy link
Member

ayust commented Jul 21, 2017

If a cron job run times out, currently it winds up just displaying with a yellow background (as if it were still running), and no duration / result.

It should display the duration after which it timed out, and a result of 'timeout'

@7sempra
Copy link
Collaborator

7sempra commented Jul 21, 2017

"timeout" should probably be a separate flag from result. A task that timed out might still finish successfully, or it might fail in a particular way that matters.

@ayust
Copy link
Member Author

ayust commented Jul 22, 2017

Hm. What is your expectation for what happens when something times out? I would expect a task that times out to be killed, and thus generally be a failure.

@7sempra
Copy link
Collaborator

7sempra commented Jul 22, 2017

So, we currently can't kill tasks that exceed their timeout window (at least, not in a reliable way). So we have to wait for them to finish, or not.

However, we could get around this by actually moving the tasks onto individual Web Workers. Those can be terminated, but it probably makes other orchestration a bit harder. Worth some investigation.

@7sempra
Copy link
Collaborator

7sempra commented Jul 23, 2017

...or just move to an actual job management framework like Kue: https://github.com/Automattic/kue

@ayust
Copy link
Member Author

ayust commented Jul 23, 2017

yeah but let's not introduce another entire database just to be able to kill cron jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants