From 26cd3c909b1223a43d353ac053ac49d9831db195 Mon Sep 17 00:00:00 2001 From: Evert Date: Fri, 19 Jul 2019 23:19:11 +0200 Subject: [PATCH] =?UTF-8?q?Partly=20fixed=20white=20line=20in=20dark=20mod?= =?UTF-8?q?e=20bug=20=F0=9F=90=9B?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Caught up with https://github.com/electron/electron/issues/13164. The eventual fix seems to have to come from Apple (--> Catalina). --- README.md | 3 ++- package.json | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index f6a58ba..2e69d67 100644 --- a/README.md +++ b/README.md @@ -12,7 +12,8 @@ PrettyEarth is [Electron](https://electronjs.org/) based. It is, to be more part Currently, only macOS is supported. However, adaptation on other operating systems will be provided soon. Few modifications are needed. ### known issues and future developements -- [ ] [macOS Mojave titlebar issue](https://github.com/electron/electron/issues/15008) (Electron related) +- [ ] [macOS Mojave white line issue in dark mode](https://github.com/electron/electron/issues/15008) (Electron related) +The Electron team have done what they could. The problem is reduced. The infamous line has become very thin and less noticeable. The underlying problem is OS-related. [Apple will probably fix the issue in Catalina.](https://github.com/electron/electron/issues/13164#issuecomment-500081463) - [ ] Windows support ## Build diff --git a/package.json b/package.json index 6840bd1..b761f7f 100644 --- a/package.json +++ b/package.json @@ -7,7 +7,7 @@ "scripts": { "test": "echo \"Error: no test specified\" && exit 1", "start": "electron .", - "package-mac": "electron-packager . --overwrite --platform=darwin --arch=x64 --out=dist --icon=icon.icns --ignore='^/docs|^/dist|^/design'" + "package-mac": "electron-packager . --overwrite --platform=darwin --arch=x64 --out=dist --icon=icon.icns --ignore='^/docs|^/dist|^/design' --darwinDarkModeSupport=true" }, "author": "Evert De Spiegeleer", "license": "MIT",