Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Rules not applied to new nodes when they are not connected to the GUI #1002

Open
hbednar opened this issue Aug 2, 2023 · 2 comments
Open
Labels
feature a whole new feature

Comments

@hbednar
Copy link

hbednar commented Aug 2, 2023

Describe the bug
I have created some rules that are needed for all nodes but, when a new one is added or comes online these rules are not applied.

I have selected apply to all nodes and it works for the ones that are connected at that time but, no others which makes a lot more work.

Include the following information:

  • OpenSnitch version: 1.6.1
  • OS: Debian
  • Version: Sid and Bookworm
  • Window Manager: N/A
  • Kernel version: Latest for Sid or Bookworm

To Reproduce
Create and apply rule, then add new node or switch old one on.

Steps to reproduce the behavior:

  1. Create and apply rule
  2. add new node
  3. switch old one on

Post error logs:
No related errors found

@gustavo-iniguez-goya gustavo-iniguez-goya added the feature a whole new feature label Aug 2, 2023
@gustavo-iniguez-goya
Copy link
Collaborator

Hi @hbednar ,

This is more a feature request than a bug in my opinion 0:)

This will effectively change the way we apply the rules to nodes: send the rules to the nodes when they connect to the GUI, instead of being the nodes who send the rules to the GUI.

This behaviour is like it is, because we didn't have a way to store rules on the GUI, it was save on memory only, so the rules were only persistant on the nodes. But since some versions ago we can save rules to a DB on disk,

There's a benefit of adding this new working mode that I already thought some time ago: nodes could work without rules on disk, only on memory, which would make it harder for someone to know what's allowed or denied.

@gustavo-iniguez-goya gustavo-iniguez-goya changed the title [Bug] Rules Not Applied To New Nodes [Bug] Rules not applied to new nodes when they are not connected to the GUI Aug 2, 2023
@hbednar
Copy link
Author

hbednar commented Aug 3, 2023

Perhaps having a two way sync with the last updated time setting the priority and all rules stored in a db at both ends. Or if the db was small enough you could sink the hole db.

This would also give more redundancy if the ui was unavailable but, having the rules in memory does sound good but how stable would it be if the ui was not available especially if a node rebooted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a whole new feature
Projects
None yet
Development

No branches or pull requests

2 participants