Problem: transaction receipt status seems wrong

[VictorTrustyDev]

Context

evmos/x/evm/keeper/state_transition.go

Lines 214 to 231 in 72ec813

	if !res.Failed() {
	receipt.Status = ethtypes.ReceiptStatusSuccessful
	// Only call hooks if tx executed successfully.
	if err = k.PostTxProcessing(tmpCtx, msg, receipt); err != nil {
	// If hooks return error, revert the whole tx.
	res.VmError = types.ErrPostTxProcessing.Error()
	k.Logger(ctx).Error("tx post processing failed", "error", err)
	// If the tx failed in post processing hooks, we should clear the logs
	res.Logs = nil
	} else if commit != nil {
	// PostTxProcessing is successful, commit the tmpCtx
	commit()
	// Since the post-processing can alter the log, we need to update the result
	res.Logs = types.NewLogsFromEth(receipt.Logs)
	ctx.EventManager().EmitEvents(tmpCtx.EventManager().Events())
	}
	}

Transaction receipt status seems wrong

Line 215: receipt set to Success
Line 219+223: when post-processing failed, set VmError and clear the log without changing status

[linear]

ENG-2467 Issue 2275

[github-actions]

This issue is stale because it has been open 45 days with no activity. Remove Status: Stale label or comment or this will be closed in 7 days.