Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does library discard UTC offsets? #112

Open
zachheine opened this issue Sep 11, 2019 · 4 comments · May be fixed by #127
Open

Why does library discard UTC offsets? #112

zachheine opened this issue Sep 11, 2019 · 4 comments · May be fixed by #127

Comments

@zachheine
Copy link

Where an RFC 3339 compliant date-time string has a time-zone other than UTC, it is shifted to UTC. For example, the date-time string "2016-01-01T14:10:20+01:00" is shifted to "2016-01-01T13:10:20Z".

Would there be consideration to add a type that allows offsets?
@Jiia
Copy link

Jiia commented Oct 14, 2019 •
edited

+1 because of this limitation you need a separate field to transmit the timezone info if you want to display the date in some specific timezone. UTC offsets are part of the RFC 3339 spec so there's no reason not to support it.

@offero
Copy link

offero commented Dec 19, 2019 •
edited

I can see the case for both normalization and for wanting to communicate dates in their native timezones to applications. Maybe this calls for 2 types?

@mormahr
Copy link

mormahr commented Jan 15, 2020

This causes problems for me because the Date 2020-01-01T00:00+01:00 is serialized as 2019-12-31 which is probably not what you'd expect.

@thomasstep
Copy link

+1 I would like to be able to allow offsets.

@thomasstep thomasstep linked a pull request Mar 19, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allowing offset from date-time-string.
5 participants
@zachheine @offero @Jiia @mormahr @thomasstep