Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AST: Nodes for title should be shared (admonitionTitle, cardTitle) #1139

Open
rowanc1 opened this issue Apr 19, 2024 · 2 comments
Open

AST: Nodes for title should be shared (admonitionTitle, cardTitle) #1139

rowanc1 opened this issue Apr 19, 2024 · 2 comments
Assignees
@agoose77
Labels
AST Abstract Syntax Tree

Comments

@rowanc1
Copy link
Member

rowanc1 commented Apr 19, 2024

We currently have admonitionTitle, cardTitle and a number of nodes that use admonitionTitle that are not admonitions. I think that these nodes should be title as a node type, perhaps with a kind. And then be shared between admonitions, dropdowns, topics, exercises, proofs, cards, etc.
@rowanc1 rowanc1 added the AST Abstract Syntax Tree label Apr 19, 2024
@rowanc1 rowanc1 mentioned this issue Apr 19, 2024
Merged
@agoose77
Copy link
Collaborator

I'll touch this next week!

@rowanc1
Copy link
Member Author

rowanc1 commented Apr 19, 2024

@agoose77 -- if you are good with this, I can update #1132 and can leave this one for you!

@agoose77 agoose77 self-assigned this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agoose77 agoose77

Labels
AST Abstract Syntax Tree
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rowanc1 @agoose77