Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fruit Picker: Improve story/instructions #1818

Closed
junedev opened this issue Jun 29, 2022 · 12 comments · Fixed by #2202
Closed

Fruit Picker: Improve story/instructions #1818

junedev opened this issue Jun 29, 2022 · 12 comments · Fixed by #2202
Assignees
Labels
x:action/improve Improve existing functionality/content x:knowledge/elementary Little Exercism knowledge required x:module/concept-exercise Work on Concept Exercises x:rep/small Small amount of reputation x:status/claimed Someone is working on this issue x:type/content Work on content (e.g. exercises, concepts)

Comments

@junedev
Copy link
Member

junedev commented Jun 29, 2022

Follow up from #1725 (comment)

Some tasks in the fruit picker exercise are currently rather "technical" instead of being phrased in terms of the overall story. Maybe someone has a good idea who to improve this.

https://github.com/exercism/javascript/blob/main/exercises/concept/fruit-picker/.docs/instructions.md

General documentation: https://exercism.org/docs/building/tracks/concept-exercises#h-file-docs-instructions-md

@junedev junedev added x:action/improve Improve existing functionality/content x:knowledge/elementary Little Exercism knowledge required x:module/concept-exercise Work on Concept Exercises x:type/content Work on content (e.g. exercises, concepts) x:rep/small Small amount of reputation labels Jun 29, 2022
@Aliwahid17

This comment was marked as off-topic.

@junedev

This comment was marked as resolved.

@Aliwahid17

This comment was marked as resolved.

@mannyistyping
Copy link

Hi @junedev 👋🏽

I'd be happy to take on this issue if that's alright?

I've been going through the exercises within the Go track and I can see how the instructions on the JS track may come off as "technical"...

ex. " Create a callback to be called when the order is successful`
Write a callback function called onSuccess to be called when the order is successful. It should invoke the imported notify function passing a success message to it.

An alternative could be...

1.Let the user know the order is successful

Define the onSuccess() function that will be called when the order is successful. This function will pass { message: 'SUCCESS' } to the notify() function which indicates that the order completed successfully.

@junedev , Is this more more inline with what you imagine to be less "technical" and more in tune with the story?

Additionally in the Instructions prompt I imagine there could be additional elaboration on the tasks to be completed and some additional backstory to the fruit-picking?
I look at annalyns-infiltration as an example where there is some story and a setting of expectations of what the tasks to complete will be.

@junedev

This comment was marked as outdated.

@junedev junedev added the x:status/claimed Someone is working on this issue label Aug 14, 2022
@mannyistyping

This comment was marked as outdated.

@alexmitchelldev

This comment was marked as resolved.

@mannyistyping

This comment was marked as resolved.

@alexmitchelldev

This comment was marked as resolved.

@mannyistyping

This comment was marked as resolved.

@SleeplessByte
Copy link
Member

Re-assigned!

@alexmitchelldev
Copy link
Contributor

alexmitchelldev commented Jun 28, 2023

@SleeplessByte could you take a look at the above PR I submitted please? Also, I noticed #1833 is still open. I'd be happy to look at this as well, please assign to me if you'd like me to 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/improve Improve existing functionality/content x:knowledge/elementary Little Exercism knowledge required x:module/concept-exercise Work on Concept Exercises x:rep/small Small amount of reputation x:status/claimed Someone is working on this issue x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants