Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Prevent ora flooding logs #2375

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

sjchmiela
Copy link
Contributor

@sjchmiela sjchmiela commented May 10, 2024

Why

I noticed logs look off in CI when running eas update --auto.

Zrzut ekranu 2024-05-10 o 17 50 10

How

I pinpointed it to Ora being restarted on every log.

Test Plan

Ran CI=1 easd update --auto and got ⬇️ which I think is much more readable.

CI=1 easd update --auto
- Exporting...
[expo-cli] Starting Metro Bundler
[expo-cli] Android Bundling complete 3492ms
[expo-cli] iOS Bundling complete 3493ms
[expo-cli] iOS Building Hermes bytecode for the bundle
[expo-cli] Android Building Hermes bytecode for the bundle
[expo-cli] 
[expo-cli] Bundle                      Size
[expo-cli] ┌ index.ios.hbc           858 kB
[expo-cli] ├ index.android.hbc       864 kB
[expo-cli] ├ index.ios.hbc.map      3.45 MB
[expo-cli] └ index.android.hbc.map  3.48 MB
[expo-cli] 
[expo-cli] 💡 JavaScript bundle sizes affect startup time. Learn more: https://expo.fyi/javascript-bundle-sizes
[expo-cli] Finished saving JS Bundles
[expo-cli] Dumping asset map
[expo-cli] Dumping source maps
[expo-cli] Preparing additional debugging files
[expo-cli] Export was successful. Your exported files can be found in dist
✔ Exported bundle(s)
- Uploading...
✔ Uploaded 2 app bundles
✔ Uploading assets skipped - no new assets found
ℹ 1 iOS asset, 1 Android asset (maximum: 20000 total per update). Learn more about asset limits: https://expo.fyi/eas-update-asset-limits
- Publishing...
✔ Published!

@sjchmiela sjchmiela changed the title Prevent ora flooding logs Prevent ora flooding logs May 10, 2024
@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label May 10, 2024
@sjchmiela sjchmiela marked this pull request as ready for review May 10, 2024 15:52
@sjchmiela sjchmiela requested review from keith-kurak and EvanBacon and removed request for khamilowicz and szdziedzic May 10, 2024 15:52
Copy link

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@sjchmiela sjchmiela changed the title Prevent ora flooding logs [eas-cli] Prevent ora flooding logs May 10, 2024
Copy link

Size Change: +937 B (0%)

Total Size: 51.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.3 MB +937 B (0%)

compressed-size-action

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 53.55%. Comparing base (2260f74) to head (374ae7d).
Report is 1 commits behind head on main.

Files Patch % Lines
packages/eas-cli/src/ora.ts 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2375      +/-   ##
==========================================
- Coverage   53.56%   53.55%   -0.00%     
==========================================
  Files         530      530              
  Lines       19512    19513       +1     
  Branches     4134     4135       +1     
==========================================
  Hits        10449    10449              
  Misses       8332     8332              
- Partials      731      732       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjchmiela sjchmiela merged commit 05be162 into main May 10, 2024
9 of 10 checks passed
@sjchmiela sjchmiela deleted the stanley/ora-repeated-lines-fix branch May 10, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants